Skip to content

[Excel] (Chart) Add leader lines snippet #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 12, 2025

Conversation

alison-mk
Copy link
Contributor

@alison-mk alison-mk commented Jul 18, 2025

This PR adds a sample showing how to adjust leader lines for chart data labels.

@alison-mk alison-mk requested a review from Copilot July 18, 2025 17:34
Copilot

This comment was marked as outdated.

@alison-mk alison-mk requested a review from Copilot July 18, 2025 18:38
Copilot

This comment was marked as outdated.

@alison-mk alison-mk requested a review from Copilot August 11, 2025 23:33
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive sample demonstrating how to work with leader lines for chart data labels in Excel. The sample shows how to enable, disable, and format leader lines, which are visual connectors between data labels and their corresponding chart points.

Key changes:

  • Adds a new leader lines snippet with functions to manipulate leader line visibility and formatting
  • Updates configuration files to include the new sample in both development and production environments
  • Generates corresponding API documentation snippets for the Excel Office.js library

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
view/excel.json Adds reference to the leader lines sample for development environment
view-prod/excel.json Adds reference to the leader lines sample for production environment
snippet-extractor-output/snippets.yaml Generates API documentation snippets for leader lines functionality
samples/excel/10-chart/chart-leader-lines.yaml New complete sample demonstrating leader lines manipulation with setup, enable/disable, and formatting functions
playlists/excel.yaml Adds leader lines sample to development playlist
playlists-prod/excel.yaml Adds leader lines sample to production playlist

@alison-mk alison-mk marked this pull request as ready for review August 11, 2025 23:37
@alison-mk alison-mk requested a review from davidchesnut August 11, 2025 23:38
Copy link
Member

@davidchesnut davidchesnut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions. Looks good!

@alison-mk
Copy link
Contributor Author

Thanks for the review, @davidchesnut! I incorporated your feedback. Could you review and approve again? This repo has special rules—since I pushed new changes (to incorporate your feedback), I'm not allowed to merge until you approve again. Keep in mind that the only file you should review is chart-leader-lines.yaml. All the other changed files are autogenerated by yarn. Thank you!

@alison-mk alison-mk requested a review from davidchesnut August 12, 2025 22:14
Copy link
Member

@davidchesnut davidchesnut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@alison-mk alison-mk merged commit 5e7fc44 into main Aug 12, 2025
1 check passed
@alison-mk alison-mk deleted the alison-mk-chart-leader-lines-2 branch August 12, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants